chore(modal-navigation-app): Add modal-navigation test app #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
MartoYankov
previously approved these changes
Jun 4, 2018
| @@ -0,0 +1,12 @@ | |||
| <TabView #rootLayout androidTabsPosition="bottom" | |||
There was a problem hiding this comment.
Remove file as TabView in modal won't work in Angular
| <Button text="Show Modal Page With Frame" (tap)="onModalFrame()"></Button> | ||
| <Button text="Navigate To Second Page" (tap)="onNavigateSecond()"></Button> | ||
| <Button text="Reset Frame Root View" (tap)="onFrameRootViewReset()"></Button> | ||
| <Button text="Reset Tab Root View" (tap)="onTabRootViewReset"></Button> |
|
|
||
| @Component({ | ||
| selector: "ns-router", | ||
| templateUrl: "app.component.html", |
There was a problem hiding this comment.
I believe this should be ./modal-router.component.html.
ADjenkov
force-pushed
the
djenkov/modal-navigation
branch
from
b78b3ce to
7676ed6
Compare
MartoYankov
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.